Repository navigation
feat(catalogs): a Named Stars catalog of every IAU-named star, numbered by Hipparcos - #695
Merged
Merged
Conversation
…cos star One listing per HIP number the IAU Catalog of Star Names (WGSN) gives, 578 stars, numbered by that number (Vega is Nam 91262) so the numbers stay put as the WGSN adopts names. Position and V from Hipparcos (V the star's own, else its system's combined light); no names of its own: add_wgsn_names names each. The star-identity stage identifies a HIP-numbered listing by its number alone: it takes no part in the cross-match or the rules, so no other match changes, and the merge joins it to the star they identify. 363 listings join an existing star, 215 become new sky objects (137 of them naked-eye). The catalog is in both Stars... menus beside Bright Named, which stays. The object list's jump-to-number takes as many digits as the list's largest sequence (6 for Nam and WDS, was 4). Refs #670 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # python/PiFinder/catalog_imports/star_identity.py
An observing list saves a Named Stars listing as "Nam 91262", and reads it back to the same listing. No source names a star "Nam <n>", so no import join changes. Refs #670 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Nov 10, 2026
15 tasks done
Zhuohang-Shen
pushed a commit
to Zhuohang-Shen/PiFinder
that referenced
this pull request
Nov 15, 2026
Brings in 24 commits of brickbots main: the catalog import fixes (brickbots#671 to brickbots#694), the Named Stars catalog (brickbots#695), the names view of the object list (brickbots#696), the Pi OS side of the migration (brickbots#657), the release workflow (brickbots#658), the OLED SPI clock (brickbots#701) and CI changes. Conflicts and their resolution: - Pi OS migration files (migration_gate.json, migration_progress, migration_progress.c, nixos_migration_calc.py): nixos keeps them deleted. They belong to the Pi OS line. - noxfile.py, requirements_dev.txt: nixos keeps them deleted. The flake dev shell and uv2nix replace them. - ui/software.py, tests/test_software.py, sys_utils.py, main.py: nixos keeps its own software screen. Its keep_awake and on_battery are the same feature as upstream's. The migration UI stays out of nixos. - catalog_imports: upstream's code. The parser moved to designations.py, so the local copy of parse_designation goes. The Perek-Kohoutek loader stays and runs before the Named Stars loader. - catalogs.py: upstream's NAME_MODE_CATALOGS. The T9 tables stay in catalog_arrays.py. - object_details.py: upstream's listing index (brickbots#678), with a search on the listing_key column for an ObjectSequence. - obslist.py and its tests: the name index of nixos (resolvers) with upstream's ambiguous designation check. - tests/test_ui_modules.py: upstream's comet retry stub, the catalog build of nixos (no background loader). - docs/ax/catalog.md, CONTEXT.md: text of both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zhuohang-Shen
pushed a commit
to Zhuohang-Shen/PiFinder
that referenced
this pull request
Nov 15, 2026
…fixes The committed database was built before the catalog import changes of upstream main. It now holds the Named Stars catalog (578 stars) and the import fixes (brickbots#681, brickbots#683, brickbots#685, brickbots#691, brickbots#692, brickbots#694, brickbots#695). EGC has 102 objects (was 91) and SaM 2157 (was 2162). IC 1805 is now one object with Sh2 190 and Lyn 77, of type cluster with nebula. The catalog data test has the new values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brickbots
added a commit
that referenced
this pull request
Nov 19, 2026
…xes (#670) — squash-merge only (#697) * fix(catalog-corrections): NGC 771 is the star 50 Cas, Named Stars' Gang Corwin's NGC notes: "NGC 771 = 50 Cassiopeiae is a star" (an A1 V star, no nebulosity on the POSS1). 50 Cas is HIP 9598, IAU name Gang, which #695 lists as Nam 9598. The listing joins that star; the match guard accepts the join (both type *, 0.04' apart). Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * data(catalog): rebuild pifinder_objects.db with the catalog-audit fixes The one rebuild for the catalog-audit campaign. It carries the import, loader, star-identity and correction changes of #671 to #696, and the NGC 771 correction before it. Built from a fresh file with `python -m PiFinder.catalog_imports.main`; two builds with different PYTHONHASHSEED values are byte-identical: sha256 03b6bcb3288b1a2909e4fedb49559f46517c7bf4e3f13ad097f848f2c5ad670e All 225 corrections apply (70 of them hip identifications). Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(catalog-data): assert the rebuilt database and the campaign's main fixes test_catalog_data.py reads the committed database, so its assertions land with the rebuild: 22 catalogs, EGC 102, SaM 2157 (rejected pairs skipped), Nam 578, and IC 1805 typed C+N (Trumpler "n", #676). New assertions, each read from the rebuilt file: the M 82 and M 57 preferred names; a not-found NGC object's description; Mizar as one D* sky object with its Str, SaM, WDS and Nam listings and the double-star filter magnitude; Vega's V 0.03 and Hipparcos position; SaM 1019 on HIP 44804; IC 2145 joined to NGC 2086, NGC 771 to Nam 9598, and Gumala one object (WDS 99456 + Nam 94645); Dhanuśarāgra with its diacritics. docs/ax/catalog.md §9: the status note goes, since the committed database now matches the import §9 describes. Its code map and the ADR 0046 link stay, as a plain paragraph. The compressed size is about 24 MB. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(catalog-import): read Collinder's two name columns, not their raw text load_collinder added the raw text of collinder.txt's "NGC/Other Cat." column and of collinder2.txt's "Other names" column as names. "581 (M103)" stayed a plain name, so Col 14 was a second sky object 0.1' from M 103, and Col 399 carried "4-5 Vul." and the one name "Al Sufi's Cluster, Brocchi's Cluster, Coathanger". The loader now reads both columns (collinder_names): - a designation is written out: "581 (M103)" is "NGC 581" and "M 103", "IC1848" is "IC 1848", "Tr.9" is "Trumpler 9". 29 Collinder listings now join the Messier, NGC or IC object that Collinder names (26 Messier clusters, Col 334 = NGC 6374, Col 382 = IC 4725, Col 26 = IC 1805); - "(incorrectly) 3247" gives no name, so Col 220 can never join NGC 3247; - "nl", the star numbers "4-5 Vul." and "9-12 Gem", and notes in parentheses ("(PMC)", "(Mel 72 per A/H)") are no names; - "2384a" is the name "NGC 2384a", which joins nothing; - a comma list is separate names, and a name is listed once. The IC 2602 correction removed "Theta Carinae Cluster, Southern Pleiades". The loader now splits that list, so the correction is deleted. Refs #670 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * data(catalog): rebuild pifinder_objects.db with the Collinder name fix A fresh-file build of this branch (the database was deleted first), after the Collinder loader fix. Two builds with PYTHONHASHSEED=1 and 4242 are byte-identical: sha256 c3cdb493338f57a4c01d8d69b4170039b8dffedf991b4b93ce73ed961dad861d The import loads and applies all 224 corrections. Against the first rebuild of this branch (ead7120, sha256 03b6bcb3...): 146,631 -> 146,602 sky objects, because 29 Collinder listings now share the Messier, NGC or IC object that Collinder names. The 151,754 catalog listings are the same. No other join changed. This replaces ead7120's database. Squash-merge the pull request, so that only this version of the file lands on main. Refs #670 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * test(catalog-data): assert the Collinder name fix in the rebuilt database Col 399 has "Al Sufi's Cluster", "Brocchi's Cluster" and "Coathanger" as three names, and no "4-5 Vul.". Col 14, 189, 382, 26 and 334 share the Messier, NGC or IC object that Collinder names; M 44 keeps "Beehive Cluster" first, and IC 1805 keeps its type C+N. Col 220 is not NGC 3247, and Col 142 ("NGC 2384a") is not NGC 2384. No Collinder name holds raw column text. Refs #670 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * docs(release-notes): the 2.6.4 catalog changes, as an appendix the release notes link to Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(catalog-import): every WDS pair is a double star unless WDS marks it dubious The D* rule's WDS clause now types a WDS listing D* if any of its pairs has a companion magnitude and is not noted X (dubious). Optical pairs (S, U, Y, L), pairs without the primary (BC), and pairs of any separation or magnitude difference count. The type says what the object is; visibility is for the filters (a double filters by its brighter star) and for the separation and magnitudes the entry shows. This follows mrosseel's review of #697. The old limits (0.5-60", 5 mag, primary only, no optical flags) typed 40,788 of 131,303 WDS listings single; the new rule types 10,597 single. The Vega (SaM 1241) and Fomalhaut (SaM 1633) obj_type corrections are deleted: they undid the old rule for optical/wide companions, and both stars are now D* by WDS, as SAC lists them. zeta Scl's (SaM 1745, only pair X-flagged) agrees with the new rule and stays. 222 corrections. The type still affects no match: the match guard treats * and D* alike (is_star_type), and the star identity reads the type only to type the merged star. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * data(catalog): rebuild pifinder_objects.db with the WDS double-star rule Every WDS pair is a double star unless WDS marks it dubious (X) or gives no companion magnitude. Objects typed D*: 91,444 -> 121,232; WDS listings D*: 90,916 -> 120,706. Only types change against the previous build (c3cdb493...): 30,049 listings go from * to D*, no join, value, name or image changes. 222 corrections apply clean. Two fresh builds (PYTHONHASHSEED=1 and 4242) are byte-identical: sha256 474d0331a5bfacebb90b2f2cfd08c1e1db1ca24ac18efc92459aedecf35a52c7 Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(catalog-data): assert the WDS double-star rule in the rebuilt database Atria (optical pair WFC 179) and Suhail (SEE 109, 12.6 mag fainter) are D*; Arcturus (only pair HDS 2003, flagged X) is *; Vega is D*. WDS listings by type: 120,706 D*, 10,597 *. The 2.6.4 catalog release note gets a "Double stars follow WDS" bullet. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IAU gives official names to about 580 stars. Before this change, PiFinder knew a star's IAU name only when another PiFinder catalog listed that star. Many bright stars were missing, for example Miaplacidus, Naos and Pherkad. This change adds a new catalog, Named Stars, with one entry for each star that has an IAU name. You can now type a star's name in Name Search and find it. The catalog is in the Stars... menu, next to Bright Named.
Each entry has the star's Hipparcos number. Hipparcos is a star catalog from a space telescope that measured about 118,000 stars. Vega shows as Nam 91262. These numbers do not change when the IAU adds new names.
Refs #670.
What changes for the user
Nam), in both Stars... menus: the catalog list and the filter.Str) does not change. It stays the short list for telescope alignment.designations.py).default_config.json), so the default object lists do not change.The 73 IAU names that have no Hipparcos number are not in the catalog. They are mostly faint stars that have planets. The catalog description says this.
How it works
The loader
catalog_imports/named_stars_loader.pyreadsastro_data/iau_wgsn/iau_csn.tsv(from #691). It makes one listing for each different HIP number in the table.load_hipparcos).*. The star-identity stage setsD*by its rule when listings merge.A, this is the star's own light. Otherwise it is the light of the full system. I chose the combined V, not "no V", for these reasons:filter_mag99. Every magnitude filter then removes it.D*with[A, B], because that counts B two times.)replace_hipparcos_valuesdoes not change a V that is not the star's own. So the combined V stays only on the 213 objects that only Named Stars lists.add_wgsn_names(from fix(catalog-import): star positions, brightness and IAU names from Hipparcos and the WGSN #691) gives each star its IAU name and the ASCII form. So a star gets its IAU name one time only.CATALOG_LOADERS. Its listings do not join anything when they are inserted (find_object_id=False).Identity: the listing is its HIP number
In
star_identity.py:HIP_NUMBERED_CATALOGS = {"Nam"}.Namis added toSTAR_CATALOGS.identify_starskeeps the HIP-numbered listings out ofmatch_stars(the position match, the vetoes, thehipcorrections and the exact-identifier rules, from fix(catalog): filter a double star by its brightest magnitude, and match stars only on independent evidence #692). Those steps see only the other listings, so no other match can change.hip_numbered_matchesthen gives each Named Stars listing its own number, with the ruleHIP number._star_groups) joins all sky objects that have the same HIP. The lowest id stays. Named Stars loads last, so the existing star keeps its sky object.hipcorrection identifies the missed listing.hipcorrection names a Named Stars listing, if the WGSN gives a HIP number that Hipparcos does not have, or if a Named Stars sky object has another listing.hipcorrections and the precision rules do not change.HIP 72105 (Izar and Pulcherrima)
ε Boo has two IAU names, and the IAU does not say which star of the pair each name is for. #691 adds neither name. This does not change. Nam 72105 is on ε Boo (with SaM 202, Str 45 and WDS 76503). Search still finds it as "Izar", from the bright-stars list. "Pulcherrima" is not added.
Data effect
Two fresh-file builds: the base is
origin/mainat 4da2a0a (after #692 and #693), then this branch.V of the Named Stars entries:
Matches by rule are the same as the base: position 23,824, catalog number 827, WDS designation 197, WDS designation and catalog number 9, SAC system 112. The only addition is
HIP number578. All 134,074 base star sky objects have the same HIP, rule, reason and listings. All 2,156 base merges are the same.Reproducible: fresh-file builds with
PYTHONHASHSEED0 and 1 (and 98765 before the merge of main) are byte-identical (SHA-2565015e042…7c2d46ef).Possible miss (for a later correction)
One new Named Stars object is on a WDS listing that the rules did not identify, because its V is more than 1 mag from the Hipparcos V. This star now has two sky objects until a
hipcorrection joins them:Also, NGC 771 (type
*) is 0.04′ from Gang (HIP 9598). That is asame_asquestion, not star identity. Each one needs a cited check, so this PR does not add corrections. They can go in the corrections PR (#694).Not in this PR
pifinder_objects.dbis not committed. PR 7b rebuilds it one time.Tests
tests/test_catalog_named_stars.py(new, 16 tests): the loader reads the table; sequence = HIP; one listing for a HIP with two names; no listing for a name with no HIP; positions are Hipparcos at J2000 (Arcturus, checked by hand fromhip_main.dat); own and combined V; the description counts match the table; a listing joins the star that Str, SAC and WDS list (Mizar) and the merged star isD*; a star that no catalog lists stays its own sky object; a listing never joins by position; ahipcorrection joins a missed listing to it; a listing takes nohipcorrection; the listings change no other match; the IAU name is added one time; Izar keeps its names and gets neither IAU name; with the real table and Hipparcos, search finds Miaplacidus, Naos and Pherkad (and Mönch as "Monch").tests/test_obslist_designations.py: "Nam 91262" reads back.tests/test_object_list_jump.py(new): a 6-digit jump; a 4-digit catalog keeps 4 digits; a leading zero opens no input.Docs
docs/source/catalogs.rst: aNamentry;Strpoints to it.docs/source/menu_map.rst: the Stars... line.docs/ax/catalog.md: §9.1 (loader order), §9.3 (a HIP-numbered listing is its star), §9.4 (WGSN: every HIP name now has its star).docs/ax/catalog/CONTEXT.md: Sequence is the HIP number inNam.🤖 Generated with Claude Code